http://www.slony.info/bugzilla/show_bug.cgi?id=172

--- Comment #7 from Christopher Browne <cbbrowne at ca.afilias.info> 2010-12-15 08:30:37 PST ---
(In reply to comment #6)
> In the first patch you add a stored function store_application_name()
> wouldn't it be better for your change to slonik to use this function
> instead of duplicating the logic?
> 
> I realize that there is a bit of a chicken/egg situation here in that until
> slonik installs the slony schema the function doesn't exist so it can't be
> called.

There lies the problem...  slonik can't call it unless the function is already
there.

The alternative, I suppose, is to change the slon logic to duplicate the logic
in slonik, so we don't need to have a version-specific stored function.

> I am also not sure how I feel about querying the catalog pg_settings table for
> application name to see what version we are on.   The other way of approaching
> this is to check the server version on from the pg connection data structures
> and not set the application name accordingly  OR we can have a no-op
> implementation of store_application_name() for versions < 9.0.

I'm uninterested in what version we are on; I am interested in whether or not
Postgres supports the GUC "application_name".  If we handle this feature that
way, then we never have to ask what version it is tied to, because it doesn't
matter.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.