<div dir="ltr">I haven't tested it, but from the diff it seems that <a href="http://slon_kill.pl">slon_kill.pl</a> message still needs some fixing.<br><br><a href="http://main.slony.info/viewcvs/viewvc.cgi/slony1-engine/tools/altperl/slon_kill.pl?r1=1.14&r2=1.15&diff_format=h">http://main.slony.info/viewcvs/viewvc.cgi/slony1-engine/tools/altperl/slon_kill.pl?r1=1.14&r2=1.15&diff_format=h</a><br>
<br>This might cause messages like:<br><when killing watchdog><br>No slon_watchdog _watchdog is running for the cluster mycluster!<br><br>OR<br><when killing slon><br>
No slon_watchdog is running for the cluster mycluster!<br>
<br>Also, there are spurious spaces before the word "is"; 2 when killing watchdog, and 3 when killing slon.<br><br>Regards, <br><br><div class="gmail_quote">On Fri, Jun 25, 2010 at 10:05 AM, Steve Singer <span dir="ltr"><<a href="mailto:ssinger@ca.afilias.info">ssinger@ca.afilias.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">Gurjeet Singh wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi All,<br>
<br>
Attached is a patch of 2.0.3 with the following:<br>
<br>
1) New script slonik_add_node. This adds the capability to add a node to the cluster. This node could be from the fact that the config file was edited to add new node's info, or maybe it was previously dropped from the cluster.<br>
</blockquote>
<br></div>
This looks fine to me<div class="im"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
2) An enhancement to the slonik_drop_node script. The original version assumed that $MASTERNODE is available for this operation to complete, but that might not always be the case. Now one needs to specify an event_node# which should be capable of sending the event notification to other nodes in the cluster.<br>
<br>
</blockquote>
<br></div>
This looks fine.<div class="im"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
For backward compatibility the new parameter can be made optional.<br>
<br>
3) A minor improvement to the message emitted by slon_kill, to differentiate between when the Slon processes are being killed vs. when the watchdog processes are being killed.<br>
<br>
</blockquote>
<br></div>
I'd rather see $watchdog_suffix passed as an argument to shut_off_process vs using a global argument. I'd also encourage declaring watchdog_suffix with my. I know the scripts don't currently work with 'use strict' but we should aim to get closer to that.<br>
<br>
Thanks for your patches. If no one else has any concerns I'll plan on committing these to the 2.0 branch sometime next week.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
Regards,<br>
-- <br>
gurjeet.singh<br>
@ EnterpriseDB - The Enterprise Postgres Company<br>
<a href="http://www.enterprisedb.com" target="_blank">http://www.enterprisedb.com</a><br>
<br>
singh.gurjeet@{ gmail | yahoo }.com<br>
Twitter/Skype: singh_gurjeet<br>
<br>
Mail sent from my BlackLaptop device<br>
<br>
<br></div>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Slony1-hackers mailing list<br>
<a href="mailto:Slony1-hackers@lists.slony.info" target="_blank">Slony1-hackers@lists.slony.info</a><br>
<a href="http://lists.slony.info/mailman/listinfo/slony1-hackers" target="_blank">http://lists.slony.info/mailman/listinfo/slony1-hackers</a><br>
</blockquote><div><div></div><div class="h5">
<br>
<br>
-- <br>
Steve Singer<br>
Afilias Canada<br>
Data Services Developer<br>
416-673-1142<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>gurjeet.singh<br>@ EnterpriseDB - The Enterprise Postgres Company<br><a href="http://www.EnterpriseDB.com">http://www.EnterpriseDB.com</a><br><br>singh.gurjeet@{ gmail | yahoo }.com<br>
Twitter/Skype: singh_gurjeet<br><br>Mail sent from my BlackLaptop device<br>
</div>