<div dir="ltr">Hi Dave,<div><br></div><div>Iam able to build the slony windows-x64 installer with Steve's patch. I've checked CMBR-499 marked as blocker. Do you want to me share the installers which are generated with above patch?</div><div><br></div><div>Can we this patch or do we need to wait for the new sources which contains the fix.</div><div><div><br></div><div><br></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 16, 2018 at 1:08 PM ZilanBasha Shaik <<a href="mailto:zilanbasha.shaik@enterprisedb.com" target="_blank">zilanbasha.shaik@enterprisedb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Steve,<div><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 16, 2018 at 6:18 AM Steve Singer <<a href="mailto:steve@ssinger.info" target="_blank">steve@ssinger.info</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, 15 Oct 2018, Steve Singer wrote:<br>
<br>
> On Mon, 15 Oct 2018, Steve Singer wrote:<br>
><br>
> And if you modify win32.mak to explicitly set PG_VERSION_MAJOR as in the <br>
> attached patch does it make the problem go away?<br></blockquote><div>with this patch compilation went fine. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Actually try this version, it will work with the other versions of PG as <br>
well. It will require the<br>
setenv PGVER=11<br>
<br>
<br>
<br>
<br>
><br>
><br>
>> On Mon, 15 Oct 2018, ZilanBasha Shaik wrote:<br>
>> <br>
>>> <br>
>>> Hi Steve,<br>
>>> On Fri, Oct 12, 2018 at 4:52 PM Steve Singer <<a href="mailto:steve@ssinger.info" target="_blank">steve@ssinger.info</a>> wrote:<br>
>>> On Fri, 12 Oct 2018, ZilanBasha Shaik wrote:<br>
>>> What is the environment variable PGVER set to?<br>
>>> It should be set to 11<br>
>>> <br>
>>> Yes, We are using the same value as you mentioned above. Hers is <br>
>>> the PG_MAJOR_VERSION=11 <br>
>> <br>
>> <br>
>> PG_MAJOR_VERSION=11<br>
>> <br>
>> or<br>
>> <br>
>> PGVER=11<br>
>> <br>
>> <br>
>><br>
>>> Steve<br>
>>> <br>
>>><br>
>>> ><br>
>>> > Hi Steve, <br>
>>> > On Thu, Oct 11, 2018 at 8:01 AM Steve Singer <<a href="mailto:steve@ssinger.info" target="_blank">steve@ssinger.info</a>> <br>
>>> wrote:<br>
>>> ><br>
>>> > ZilanBasha,<br>
>>> ><br>
>>> > The attached patch seems to get slony 2.2.7 compiling <br>
>>> against PG11 beta on<br>
>>> > Windows.<br>
>>> ><br>
>>> > Please confirm if this works.<br>
>>> ><br>
>>> ><br>
>>> > I have applied your patch in slony 2.2.7 sources. During the <br>
>>> compilation I come across the<br>
>>> below error. Here<br>
>>> > PGV11 version is RC1.<br>
>>> ><br>
>>> > Can you please help us to resolve this issue.<br>
>>> ><br>
>>> > D:\pginstaller.pune>CALL "C:\\Program Files (x86)\\Microsoft <br>
>>> Visual<br>
>>> > Studio\\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" amd64 <br>
>>> ><br>
>>> > <br>
>>> **********************************************************************<br>
>>> ><br>
>>> > ** Visual Studio 2017 Developer Command Prompt v15.7.1<br>
>>> ><br>
>>> > ** Copyright (c) 2017 Microsoft Corporation<br>
>>> ><br>
>>> > <br>
>>> **********************************************************************<br>
>>> ><br>
>>> > [vcvarsall.bat] Environment initialized for: 'x64'<br>
>>> ><br>
>>> > cl.exe/c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H <br>
>>> /I..\..\ /D HAVE_PGPORT<br>
>>> > /ID:\\pginstaller.pune\output\include <br>
>>> /ID:\\pginstaller.pune\output\include\server<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD <br>
>>> slonik.c<br>
>>> ><br>
>>> ><br>
>>> > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > slonik.c<br>
>>> ><br>
>>> > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(87): <br>
>>> warning C4005: 'va_copy': macro<br>
>>> redefinition<br>
>>> ><br>
>>> > C:\Program Files (x86)\Microsoft Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdarg.h(20): <br>
>>> note: see previous<br>
>>> definition of<br>
>>> > 'va_copy'<br>
>>> ><br>
>>> > d:\pginstaller.pune\slony.windows-x64\src\slonik\slonik.c(75) : <br>
>>> warning C4172: returning<br>
>>> address of local<br>
>>> > variable or temporary: result<br>
>>> ><br>
>>> > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H <br>
>>> /I..\..\ /D HAVE_PGPORT<br>
>>> > /ID:\\pginstaller.pune\output\include <br>
>>> /ID:\\pginstaller.pune\output\include\server<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD <br>
>>> dbutil.c<br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > dbutil.c<br>
>>> ><br>
>>> > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(87): <br>
>>> warning C4005: 'va_copy': macro<br>
>>> redefinition<br>
>>> ><br>
>>> > C:\Program Files (x86)\Microsoft Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdarg.h(20): <br>
>>> note: see previous<br>
>>> definition of<br>
>>> > 'va_copy'<br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H <br>
>>> /I..\..\ /D HAVE_PGPORT<br>
>>> > /ID:\\pginstaller.pune\output\include <br>
>>> /ID:\\pginstaller.pune\output\include\server<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD <br>
>>> parser.c<br>
>>> ><br>
>>> > parser.c<br>
>>> ><br>
>>> > C:\Program Files (x86)\Microsoft Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stddef.h(45): <br>
>>> warning C4005:<br>
>>> 'offsetof': macro<br>
>>> > redefinition<br>
>>> ><br>
>>> > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(20): <br>
>>> note: see previous definition of<br>
>>> 'offsetof'<br>
>>> ><br>
>>> > C:\Program Files (x86)\Microsoft Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdlib.h(603): <br>
>>> warning C4142:<br>
>>> '_strtoui64':<br>
>>> > benign redefinition of type<br>
>>> ><br>
>>> > C:\Program Files (x86)\Microsoft Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdlib.h(539): <br>
>>> note: see<br>
>>> declaration of<br>
>>> > '_strtoui64'<br>
>>> ><br>
>>> > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H <br>
>>> /I..\..\ /D HAVE_PGPORT<br>
>>> > /ID:\\pginstaller.pune\output\include <br>
>>> /ID:\\pginstaller.pune\output\include\server<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD <br>
>>> /Fo..\parsestatements\scanner.obj<br>
>>> > ..\parsestatements/scanner.c<br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > scanner.c<br>
>>> ><br>
>>> > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H <br>
>>> /I..\..\ /D HAVE_PGPORT<br>
>>> > /ID:\\pginstaller.pune\output\include <br>
>>> /ID:\\pginstaller.pune\output\include\server<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD scan.c<br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > scan.c<br>
>>> ><br>
>>> > link.exe /libpath:D:\\pginstaller.pune\output\lib libpq.lib <br>
>>> libpgport.lib libpgcommon.lib<br>
>>> ws2_32.lib<br>
>>> > kernel32.lib user32.lib advapi32.lib /libpath:C:\\pgBuild64\lib <br>
>>> intl.lib slonik.obj <br>
>>> dbutil.obj parser.obj <br>
>>> > ..\parsestatements\scanner.obj scan.obj<br>
>>> ><br>
>>> > Microsoft (R) Incremental Linker Version 14.14.26428.1<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for <br>
>>> x64<br>
>>> ><br>
>>> > Copyright (C) Microsoft Corporation. All rights reserved.<br>
>>> ><br>
>>> ><br>
>>> > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /I..\misc /I..\..\<br>
>>> /ID:\\pginstaller.pune\output\include<br>
>>> > /ID:\\pginstaller.pune\output\include\server <br>
>>> /ID:\\pginstaller.pune\output\include\server\port\win32_msvc<br>
>>> > /ID:\\pginstaller.pune\output\include\server\port\win32 <br>
>>> /IC:\\pgBuild64\include /D<br>
>>> HAVE_LL_CONSTANTS=1 /D<br>
>>> > HAVE_GETACTIVESNAPSHOT /LD /Gd /Tc slony1_funcs.c<br>
>>> ><br>
>>> > slony1_funcs.c<br>
>>> ><br>
>>> > slony1_funcs.c(2904): error C2232: '->attisdropped': left operand <br>
>>> has 'struct' type, use '.'<br>
>>> ><br>
>>> > slony1_funcs.c(2904): warning C4033: 'isDropped' must return a <br>
>>> value<br>
>>> ><br>
>>> > slony1_funcs.c(2919): error C2232: '->atttypmod': left operand has <br>
>>> 'struct' type, use '.'<br>
>>> ><br>
>>> > slony1_funcs.c(2919): warning C4033: 'typeMod' must return a value<br>
>>> ><br>
>>> > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft <br>
>>> Visual<br>
>>> > <br>
>>> Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\bin\HostX64\x64\cl.exe"' <br>
>>> : return code<br>
>>> '0x2'<br>
>>> ><br>
>>> > Stop.<br>
>>> ><br>
>>> ><br>
>>> > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1 <br>
>>> ><br>
>>> > Steve<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > --<br>
>>> > Thank You,Shaik ZIlanBasha<br>
>>> ><br>
>>> ><br>
>>> <br>
>>> <br>
>>> <br>
>>> --<br>
>>> Thank You,Shaik ZIlanBasha<br>
>>> <br>
>>> <br>
>> <br>
><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_5846470259952808796m_-4789791658828743734gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Thank You,<div>Shaik ZIlanBasha</div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_5846470259952808796gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Thank You,<div>Shaik ZIlanBasha</div></div></div>