On Mon, 15 Oct 2018, ZilanBasha Shaik wrote:

> 
> Hi Steve,
> On Fri, Oct 12, 2018 at 4:52 PM Steve Singer <steve at ssinger.info> wrote:
>       On Fri, 12 Oct 2018, ZilanBasha Shaik wrote:
>       What is the environment variable PGVER set to?
>       It should be set to 11
> 
> Yes, We are using the same value as you mentioned above.  Hers is the PG_MAJOR_VERSION=11 


PG_MAJOR_VERSION=11

or

PGVER=11



>       Steve
> 
>
>       >
>       > Hi Steve, 
>       > On Thu, Oct 11, 2018 at 8:01 AM Steve Singer <steve at ssinger.info> wrote:
>       >
>       >       ZilanBasha,
>       >
>       >       The attached patch seems to get slony 2.2.7 compiling against PG11 beta on
>       >       Windows.
>       >
>       >       Please confirm if this works.
>       >
>       >
>       > I have applied your patch in slony 2.2.7 sources. During the compilation I come across the
>       below error. Here
>       > PGV11 version is RC1.
>       >
>       > Can you please help us to resolve this issue.
>       >
>       > D:\pginstaller.pune>CALL "C:\\Program Files (x86)\\Microsoft Visual
>       > Studio\\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" amd64 
>       >
>       > **********************************************************************
>       >
>       > ** Visual Studio 2017 Developer Command Prompt v15.7.1
>       >
>       > ** Copyright (c) 2017 Microsoft Corporation
>       >
>       > **********************************************************************
>       >
>       > [vcvarsall.bat] Environment initialized for: 'x64'
>       >
>       > cl.exe/c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H /I..\..\ /D HAVE_PGPORT
>       > /ID:\\pginstaller.pune\output\include /ID:\\pginstaller.pune\output\include\server
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD  slonik.c
>       >
>       >
>       > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > slonik.c
>       >
>       > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(87): warning C4005: 'va_copy': macro
>       redefinition
>       >
>       > C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdarg.h(20): note: see previous
>       definition of
>       > 'va_copy'
>       >
>       > d:\pginstaller.pune\slony.windows-x64\src\slonik\slonik.c(75) : warning C4172: returning
>       address of local
>       > variable or temporary: result
>       >
>       > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H /I..\..\ /D HAVE_PGPORT
>       > /ID:\\pginstaller.pune\output\include /ID:\\pginstaller.pune\output\include\server
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD dbutil.c
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > dbutil.c
>       >
>       > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(87): warning C4005: 'va_copy': macro
>       redefinition
>       >
>       > C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdarg.h(20): note: see previous
>       definition of
>       > 'va_copy'
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H /I..\..\ /D HAVE_PGPORT
>       > /ID:\\pginstaller.pune\output\include /ID:\\pginstaller.pune\output\include\server
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD parser.c
>       >
>       > parser.c
>       >
>       > C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stddef.h(45): warning C4005:
>       'offsetof': macro
>       > redefinition
>       >
>       > d:\pginstaller.pune\slony.windows-x64\src\slonik\types.h(20): note: see previous definition of
>       'offsetof'
>       >
>       > C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdlib.h(603): warning C4142:
>       '_strtoui64':
>       > benign redefinition of type
>       >
>       > C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\stdlib.h(539): note: see
>       declaration of
>       > '_strtoui64'
>       >
>       > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H /I..\..\ /D HAVE_PGPORT
>       > /ID:\\pginstaller.pune\output\include /ID:\\pginstaller.pune\output\include\server
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD /Fo..\parsestatements\scanner.obj
>       > ..\parsestatements/scanner.c
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > scanner.c
>       >
>       > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /D YY_NO_UNISTD_H /I..\..\ /D HAVE_PGPORT
>       > /ID:\\pginstaller.pune\output\include /ID:\\pginstaller.pune\output\include\server
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /MD scan.c
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > scan.c
>       >
>       > link.exe /libpath:D:\\pginstaller.pune\output\lib libpq.lib libpgport.lib libpgcommon.lib
>       ws2_32.lib
>       > kernel32.lib user32.lib advapi32.lib /libpath:C:\\pgBuild64\lib intl.lib slonik.obj 
>       dbutil.obj  parser.obj 
>       > ..\parsestatements\scanner.obj  scan.obj
>       >
>       > Microsoft (R) Incremental Linker Version 14.14.26428.1
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       >
>       > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26428.1 for x64
>       >
>       > Copyright (C) Microsoft Corporation.  All rights reserved.
>       >
>       >
>       > cl.exe /c /D MSVC /D WIN32 /D PGSHARE=\"\"\"\" /I..\misc /I..\..\
>       /ID:\\pginstaller.pune\output\include
>       > /ID:\\pginstaller.pune\output\include\server 
>       /ID:\\pginstaller.pune\output\include\server\port\win32_msvc
>       > /ID:\\pginstaller.pune\output\include\server\port\win32 /IC:\\pgBuild64\include /D
>       HAVE_LL_CONSTANTS=1 /D
>       > HAVE_GETACTIVESNAPSHOT  /LD /Gd /Tc  slony1_funcs.c
>       >
>       > slony1_funcs.c
>       >
>       > slony1_funcs.c(2904): error C2232: '->attisdropped': left operand has 'struct' type, use '.'
>       >
>       > slony1_funcs.c(2904): warning C4033: 'isDropped' must return a value
>       >
>       > slony1_funcs.c(2919): error C2232: '->atttypmod': left operand has 'struct' type, use '.'
>       >
>       > slony1_funcs.c(2919): warning C4033: 'typeMod' must return a value
>       >
>       > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
>       > Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\bin\HostX64\x64\cl.exe"' : return code
>       '0x2'
>       >
>       > Stop.
>       >
>       >
>       > Microsoft (R) Program Maintenance Utility Version 14.14.26428.1  
>       >
>       >       Steve
>       >
>       >
>       >
>       > --
>       > Thank You,Shaik ZIlanBasha
>       >
>       >
> 
> 
> 
> --
> Thank You,Shaik ZIlanBasha
> 
>