On 9/28/2007 10:33 AM, Marko Kreen wrote:
> On 9/28/07, Tom Lane <tgl at sss.pgh.pa.us> wrote:
>> "Marko Kreen" <markokr at gmail.com> writes:
>> > bool          txid_not_visible_in_snapshot(int8, snap)
>>
>> The last seems pretty thoroughly redundant?
> 
> Ehhee.  Jan, it's 2:1 now.  I also think it unecessary.

Yeah, yeah ... I can live without it. It's just, from that point of view 
half of all comparison operators are redundant ;-)

> 
>> > - removed use of "unsigned long long" in txid_snapshot_out,
>> >   instead I try to guess the correct fromat string for uint64
>> >   from HAVE_LONG_INT_64
>>
>> What's to guess?  Use UINT64_FORMAT
> 
> Thanks, I failed to notice it for some reason.
> 
> New patch attached, both things fixed.

I'll look at it later today, if I find a free minute to breathe!


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck at Yahoo.com #