On Mon, 19 Mar 2018, Jehan-Guillaume de Rorthais wrote:

Thanks.
I've pushed this change.

> Hi all,
>
> Sorry for writing on -general about a bug report, but -bugs seems spammed
> according to the archives.
>
> Despite support for PostgreSQL 10, while working with Slony 2.2.6 and
> PostgreSQL v10.3, I hit the following (common and mainly painless) warning
> message:
>
> «
> Possible unsupported PostgreSQL version (100300) 10.3, defaulting to 8.4
> support 
> »
>
> It seems to me the check in slonik.c might be wrong:
>
> https://git.postgresql.org/gitweb/?p=slony1-engine.git;a=blob;f=src/slonik/slonik.c;h=a30616129018c15f15eea60c73ffcb8c1489c4e2;hb=5aced469e8859174e84ccde031c28eaf7b30b127#l2079
>
> I suppose:
>
>  ((adminfo->pg_version >= 90000) && (adminfo->pg_version < 100000)) /* 10 */
>
> Should be:
>
>  ((adminfo->pg_version >= 90000) && (adminfo->pg_version < 110000)) /* 10 */
>
> Or maybe (considering we will not have more than 99 minor release for 10):
>
>  ((adminfo->pg_version >= 90000) && (adminfo->pg_version < 100100)) /* 10 */
>
> Indeed, 10 is 100000 and 10.3 is 100003, so (adminfo->pg_version < 100000) is
> always false for v10.x.
>
> I was volunteering to make a pull request on github, but I couldn't find up to
> date sources for 2.2.6. Last patch on REL_2_2_STABLE is almost 2 years ago:
>
> https://github.com/ssinger/slony1-engine/blob/REL_2_2_STABLE/src/slonik/slonik.c
>
> Cheers,
> _______________________________________________
> Slony1-general mailing list
> Slony1-general at lists.slony.info
> http://lists.slony.info/mailman/listinfo/slony1-general