slony1-bugs at lists.slony.info writes:
> http://www.slony.info/bugzilla/show_bug.cgi?id=46
> --- Comment #3 from Christopher Browne <cbbrowne at ca.afilias.info>  2008-09-24 11:57:00 ---
> Created an attachment (id=22)
>  --> (http://www.slony.info/bugzilla/attachment.cgi?id=22)
> Newer patch to Slony-I to run against 8.4 - uses new GetActiveSnapshot()
> function
>
> Attached is a newer patch.
>
> This needs to be modified somewhat to address the fact that 8.3 expects the
> former form, and 8.4 expects the new form.  I'll discuss that on-list.

We have the change in 8.4 that SerializableSnapshot has gone away,
with the effective replacement being the new function,
GetActiveSnapshot().

-       if (SerializableSnapshot == NULL)
-               elog(ERROR, "Slony-I: SerializableSnapshot is NULL in createEvent()");
+       if (GetActiveSnapshot() == NULL)
+               elog(ERROR, "Slony-I: ActiveSnapshot is NULL in createEvent()");

I ran some of the tests against CVS HEAD with this with success.

The open question is how best to detect that we should be using
GetActiveSnapshot() rather than SerializableSnapshot.  

Shall I detect that in configure?  That seems apropos.
-- 
output = ("cbbrowne" "@" "cbbrowne.com")
http://linuxfinances.info/info/linux.html
I'm sure  glad we're having this "How  many FTP transfers can dance on
the  head of a  chargeback   packet"  conversation now, because   when
chargebacks  happen, it  will surely  be too  expensive to  read these
amazing conversations.