On Wed, 9 Apr 2008, Christopher Browne wrote:

> Vivek Khera <vivek at khera.org> writes:
>> On Apr 8, 2008, at 4:29 PM, Jeff Frost wrote:
>>> I think if the default event node wasn't always 1, but in fact the
>>> current master, then things would be less painful when you end up
>>> with a master that isn't node id 1.
>>
>> I think it would be even better if there was NO default event node. I
>> intentionally avoid node number 1 just for this reason -- I can debug
>> my scripts much more easily.
>
> Reviewing the parser, there only seem to be the following slonik
> commands that use a default of 1:
>
>  INIT CLUSTER has default ID = 1
>  STORE NODE has default EVENT NODE = 1
>  DROP NODE has default EVENT NODE = 1
>  FAILOVER has default BACKUP NODE = 1
>  EXECUTE SCRIPT has default EVENT NODE = 1
>  UPDATE FUNCTIONS has default ID = 1
>  REPAIR CONFIG has default EVENT NODE = 1
>  WAIT FOR EVENT has default WAIT ON = 1
>
> It doesn't take a very big patch to implement the requirement that these:
> a) Default to -1, and
> b) Error out if left as -1

I think that's pretty reasonable.  It'll break all my scripts that depend on a 
default event node, but they're easily fixed.

-- 
Jeff Frost, Owner 	<jeff at frostconsultingllc.com>
Frost Consulting, LLC 	http://www.frostconsultingllc.com/
Phone: 650-780-7908	FAX: 650-649-1954