If there are no objections I'll apply this to head and the 1.1 branch in
the next day or so.

Regards, Dave. 

> -----Original Message-----
> From: slony1-general-bounces at gborg.postgresql.org 
> [mailto:slony1-general-bounces at gborg.postgresql.org] On 
> Behalf Of Andreas Pflug
> Sent: 25 September 2005 11:54
> Cc: Slony Mailing List
> Subject: Re: [Slony1-general] rebuildlistenentries for 
> enabled nodes only
> 
> Attached a patch implementing my proposal.
> 
> Regards,
> Andreas
> 
> Andreas Pflug wrote:
> > We've been discussing using nodes/paths to store information for 
> > non-slon active node, but didn't come to a conclusion so far.
> > 
> > Currently, listens will be generated for every path 
> regardless of the 
> > node's activity. If a node will never have a running slon 
> daemon, events 
> > for this node will collect and prevent cleanup of old 
> events, which is bad.
> > 
> > As a fix, I'd propose to generate listens from paths only between 
> > _active_ nodes, i.e. add "and N1.no_active and N2.no_active" to the 
> > select condition in rebuildlistenentries(). A node that's 
> not active 
> > will never process events, and never generate events so IMHO it's 
> > correct to have no listens for such nodes. In addition, 
> > rebuildlistenentries() probably needs to be added to 
> enablenode() and 
> > disablenode() (as soon as it's implemented) too.
> > 
> > Regards,
> > Andreas
> > _______________________________________________
> > Slony1-general mailing list
> > Slony1-general at gborg.postgresql.org
> > http://gborg.postgresql.org/mailman/listinfo/slony1-general
> 
>