Dave Page dpage
Mon Jul 18 21:22:22 PDT 2005
Patch applied.

/D 

> -----Original Message-----
> From: slony1-general-bounces at gborg.postgresql.org 
> [mailto:slony1-general-bounces at gborg.postgresql.org] On 
> Behalf Of Magnus Hagander
> Sent: 17 July 2005 15:46
> To: slony1-general at gborg.postgresql.org
> Subject: [Slony1-general] [PATCH] Fix for slonik get_sharepath
> 
> Hi!
> 
> The function get_sharepath() in slonik (used only on win32) is badly
> broken as it is now. For one thing, it loops on an unsigned 
> int var with
> a condition of ">=0", which is always true. Which results in 
> it happily
> overwriting argv[] (and probably other such things!) makeing it
> impossible to run a simple command like "slonik foo" (because once it
> tries to open the file, argv[1] is now NULL).
> 
> Attached patch cleans that up. Still uses the same logic (assuming I
> read the original logic correctly). It's a bit simplistic, but I think
> it will be enough for most cases.
> 
> //Magnus
> 


More information about the Slony1-general mailing list