From ssinger at ca.afilias.info Tue Sep 23 06:54:49 2014 From: ssinger at ca.afilias.info (Steve Singer) Date: Tue, 23 Sep 2014 13:54:49 +0000 Subject: [Slony1-commit] Slony-I-commit Bug 345 Message-ID: Bug 345 The strtok_r on the node list was adding replacing the comma with a NULL causing only 1 node to get inserted into sl_event. This mean any nodes that where cascaded only saw 1 of the nodes in the drop node list. Call strtok_r on a copy of the list so it can safely be munged. Also add in a DropNode cluster test to demonstrate test this issue Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=slony1-engine.git;a=commitdiff;h=33a2da34bb5243309788bdd1b51b12b53c0b5214 Modified Files -------------- clustertest/disorder/tests/DropNode.js | 86 ++++++++++++++++++++++++++ clustertest/disorder/tests/disorder_tests.js | 2 + src/slon/remote_worker.c | 5 +- 3 files changed, 91 insertions(+), 2 deletions(-) From ssinger at ca.afilias.info Tue Sep 23 06:56:01 2014 From: ssinger at ca.afilias.info (Steve Singer) Date: Tue, 23 Sep 2014 13:56:01 +0000 Subject: [Slony1-commit] Slony-I-commit Bug 345 Message-ID: Bug 345 The strtok_r on the node list was adding replacing the comma with a NULL causing only 1 node to get inserted into sl_event. This mean any nodes that where cascaded only saw 1 of the nodes in the drop node list. Call strtok_r on a copy of the list so it can safely be munged. Also add in a DropNode cluster test to demonstrate test this issue Branch ------ REL_2_2_STABLE Details ------- http://git.postgresql.org/gitweb?p=slony1-engine.git;a=commitdiff;h=5b95bdbcdb995b95c8fba12fae8bea82b2c743aa Modified Files -------------- RELEASE | 1 + clustertest/disorder/tests/DropNode.js | 86 ++++++++++++++++++++++++++ clustertest/disorder/tests/disorder_tests.js | 2 + src/slon/remote_worker.c | 5 +- 4 files changed, 92 insertions(+), 2 deletions(-)