http://www.slony.info/bugzilla/show_bug.cgi?id=337

Steve Singer <ssinger at ca.afilias.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ssinger at ca.afilias.info     |cbbrowne at ca.afilias.info

--- Comment #3 from Steve Singer <ssinger at ca.afilias.info> 2014-07-30 12:37:54 PDT ---
I'm not very happy with how this patch behaves when we start up a slon that
can't connect to a valid slony database.

Start up slon against a database that doesn't yet have slony installed or with
a dbname that doesn't exist.

This patch prints an error message for everyconfig value.

It should instead print an error about not being able to connect to the DB or
that slony is not installed, but not keep complaining about each individual
config parameter.

For example

-------------
 src/slon/slon disorder 'host=localhost dbname=tesssst'
2014-07-30 15:26:29 EDT CONFIG main: slon version 2.3.0 starting up
2014-07-30 15:26:29 EDT INFO   slon: watchdog process started
2014-07-30 15:26:29 EDT CONFIG slon: watchdog ready - pid = 30388
2014-07-30 15:26:29 EDT CONFIG slon: worker process created - pid = 30389
2014-07-30 15:26:29 EDT ERROR  dump_configuration - unable to empty sl_slonconf
- 
2014-07-30 15:26:29 EDT CONFIG main: Integer option vac_frequency = 3
2014-07-30 15:26:29 EDT ERROR  dump_configuration - unable to write sl_slonconf
entry for ('vac_frequency', '3') - 
2014-07-30 15:26:29 EDT CONFIG main: Integer option log_level = 0
2014-07-30 15:26:29 EDT ERROR  dump_configuration - unable to write sl_slonconf
entry for ('log_level', '0') - 
2014-07-30 15:26:29 EDT CONFIG main: Integer option sync_interval = 2000

.
.
.
.
2014-07-30 15:26:29 EDT FATAL  main: Cannot connect to local database - no
connection to the server
 - sleep 10s


I want to see that FATAL message first, because that is the message that
describes my problem.  (I would be inclined to do the database config writing
after , db_checkSchemaVersion in slon.c



Also maybe we want the release notes to just provide a sentence or two
description of the change and reference the documentation for the example of
the table output.

Other than those issues it looks fine.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.