http://www.slony.info/bugzilla/show_bug.cgi?id=137

--- Comment #13 from Christopher Browne <cbbrowne at ca.afilias.info> 2011-11-17 10:04:55 PST ---
(In reply to comment #9)
> 3.  In ddlchanges.sgml item 3
> I am opposed to saying in the manual that DDL can be submitted directly with
> the ddlCapture SQL function.  I feel that only slonik should be calling these
> slony functions.  By telling people in the manual that they can do this then we
> are committing to a somewhat stable API.
> I think it will also encourage people to call other slony SQL functions
> directly.
> 
> 
> The counter argument is that now that ddlChange() isn't an event it actually
> can be safely called by someone other than slonik and it allows applications
> (ie java, php,perl,python etc...) do do there own DDL without having to make a
> system() call to slonik.  I am somewhat sympathetic to this but I remind people
> that in any version prior to 2.2 this was a really bad/broken idea. Even in 2.2
> calling ddlChange() outside of slonik with more than one EVENT NODE can expose
> you to race conditions.

https://github.com/cbbrowne/slony1-engine/commit/af54adb535146a84923ae3e59c1c6c27217e1ab8

> In slonik_ref.sgml
> I would like to see any encouragement to calling ddlCapture() directly removed
> (see above for reasons)

https://github.com/cbbrowne/slony1-engine/commit/789534ca1658bcc685a59f325fe2658827d3de5c

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.