bugzilla-daemon at main.slony.info bugzilla-daemon at main.slony.info
Wed Aug 31 10:50:33 PDT 2011
http://www.slony.info/bugzilla/show_bug.cgi?id=235

Christopher Browne <cbbrowne at ca.afilias.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|slony1-bugs at lists.slony.inf |janwieck at yahoo.com
                   |o                           |
             Status|NEW                         |ASSIGNED
         OS/Version|Linux                       |All
           Platform|PC                          |All
            Version|2.0                         |devel

--- Comment #12 from Christopher Browne <cbbrowne at ca.afilias.info> 2011-08-31 10:50:33 PDT ---
(In reply to comment #11)
> I have set up a branch for this that prototypes the proposed changes.
> 
> https://github.com/cbbrowne/slony1-engine/tree/bug235
> 
> There are a few issues outstanding at the moment:
> 
> 1.  There's still a little question as to whether we start with grouping size
> of 1, or if we go for something higher.
> 
> I'm assuming 1, at the moment, which has the merit that this is how Slony
> already behaves.

According to further discussion that has taken place, there is general
agreement that this is the right place to start.

> 2.  I'm logging the result of the computation at SLON_INFO level, which is not
> the right verbosity level.

Fixed.

> 3.  There isn't a good test that validates the behaviour.  None of the
> regression tests are really suitable, as they do not impose any big backlogs.

This isn't something that is amenable to any of our automated testing; it does
not seem appropriate to add any explicit test to the suite.

The apropos test is more "observational"; just...

- Set up a cluster

- Set up a data source that's injecting updates to the origin node

- Manually stop and start a slon, having debugging set to a level that shows
off the SYNC grouping computation.  Stop the slon to let some SYNCs build up,
restart to see how it catches up.

All worked fine for me.

This is apropos as a post-2.1 change; once we open development of 2.1, it
should go to Steve/Jan for review.  Assigning it to Jan to arrange review.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Slony1-bugs mailing list