http://www.slony.info/bugzilla/show_bug.cgi?id=104

--- Comment #2 from Christopher Browne <cbbrowne at ca.afilias.info> 2010-06-01 13:18:35 PDT ---
(In reply to comment #1)
> Created an attachment (id=44)
 --> (http://www.slony.info/bugzilla/attachment.cgi?id=44) [details]
> Fix for  bug 104
> 
> The attach fix should address the stack trace in this bug

The fix seems reasonable.

The function is called in 4 places in src/slon/scheduler.c

src/slon/scheduler.c
60:static void sched_add_fdset(int fd, fd_set * fds);
211:            sched_add_fdset(PQsocket(conn->dbconn), &sched_fdset_read);
213:            sched_add_fdset(PQsocket(conn->dbconn), &sched_fdset_write);
408:    sched_add_fdset(sched_wakeuppipe[0], &sched_fdset_read);
672: * sched_add_fdset
679:sched_add_fdset(int fd, fd_set * fds)
688: * sched_add_fdset

Is it possible that the evaluation of the socket could instead be processed
inside the function?  That would mean that the same validity test would be
applied for the other 2 cases as well, and it might very well simplify the
code.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.