http://www.slony.info/bugzilla/show_bug.cgi?id=115

--- Comment #6 from Christopher Browne <cbbrowne at ca.afilias.info> 2010-08-25 13:11:40 PDT ---
Created an attachment (id=61)
 --> (http://www.slony.info/bugzilla/attachment.cgi?id=61)
Test case that may go in "tests" directory

I added, in a private branch, a test case for this.

postgres at cbbrowne [04:05:53] [~/slony1-engine.github/tests] [bug115 *]
-> % ./run_test.sh testbadtry
test: testbadtry
----------------------------------------------------
This test involves validating that WAIT FOR EVENT inside a TRY block
is rejected.
----------------------------------------------------
Test by j.random.luser at example.net to be summarized in
/tmp/Slony-I-test-results.log
creating origin DB: postgres -h localhost -U postgres -p 7099 slonyregress1
add plpgsql to Origin
createlang: language "plpgsql" is already installed in database "slonyregress1"
loading origin DB with testbadtry/init_schema.sql
setting up user postgres to have weak access to data
done
creating subscriber 2 DB: postgres -h localhost -U postgres -p 7099
slonyregress2
add plpgsql to subscriber
createlang: language "plpgsql" is already installed in database "slonyregress2"
loading subscriber 2 DB from slonyregress1
done
creating cluster
done
storing nodes
done
Granting weak access on Slony-I schema
done
storing paths
done
launching originnode - PGBINDIR=/var/lib/postgresql/dbs/postgresql-HEAD/bin
[: 27: x/tmp/slony-regress.TyNj0y/slon-pid.1: unexpected operator
Starting slon: /var/lib/postgresql/dbs/postgresql-HEAD/bin/slon -f
/tmp/slony-regress.TyNj0y/slon-conf.1 1>> /tmp/slony-regress.TyNj0y/slon_log.1
2>&1 &
[: 27: x/tmp/slony-regress.TyNj0y/slon-pid.1: unexpected operator
Archive node:
Considering node 2
launching slon
[: 27: x/tmp/slony-regress.TyNj0y/slon-pid.2: unexpected operator
Starting slon: /var/lib/postgresql/dbs/postgresql-HEAD/bin/slon -f
/tmp/slony-regress.TyNj0y/slon-conf.2 1>> /tmp/slony-regress.TyNj0y/slon_log.2
2>&1 &
[: 27: x/tmp/slony-regress.TyNj0y/slon-pid.2: unexpected operator
subscribing
done
./run_test.sh: ERROR: Slonik error see /tmp/slony-regress.TyNj0y/slonik.log for
details
[: 1: xSlonik: unexpected operator

postgres at cbbrowne [04:06:32] [~/slony1-engine.github/tests] [bug115 *]
-> % cat /tmp/slony-regress.TyNj0y/slonik.log
<stdin>:2: ERROR: WAIT FOR EVENT command used inside of TRY block

Whether or not we really want to add a regression test for this is an open
question.

At any rate, this nicely verifies that it works.  I'm fine with committing it.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.